Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use go1.10.1 and go1.9.5 #39

Merged
merged 1 commit into from
Mar 31, 2018
Merged

Use go1.10.1 and go1.9.5 #39

merged 1 commit into from
Mar 31, 2018

Conversation

grobie
Copy link
Member

@grobie grobie commented Mar 31, 2018

sdurrheimer
sdurrheimer suggested changes Mar 31, 2018
View reviewed changes
Copy link
Contributor

@sdurrheimer sdurrheimer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@grobie You need to change 1.10/Makefile.COMMON and 1.9/Makefile.COMMON too.

@grobie
Use go1.10.1 and go1.9.5
0c07722 
The latest patch versions include two important fixes for the Prometheus
project:

* golang/go#23995
* golang/go#24059
@grobie
Copy link
Member Author

grobie commented Mar 31, 2018

Thanks, updated.

@grobie grobie merged commit f0f4e83 into master Mar 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sdurrheimer sdurrheimer sdurrheimer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@grobie @sdurrheimer