Add rcodesign installation to golang-builder #242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@SuperQ did you have any feedback for this? |
SuperQ
reviewed
Feb 5, 2024
SuperQ
reviewed
Feb 5, 2024
gitperr
force-pushed
the
master
branch
2 times, most recently
from
84cf3b5
to
6fd9f07
Compare
SuperQ
reviewed
Feb 5, 2024
Signed-off-by: Alper Polat <[email protected]> Install rust and rcodesign This method was chosen because rust shipped with debian is 1.63.0, which does not seem to be sufficient for the binary to be built. So, we have to install rust from source. Signed-off-by: Alper Polat <[email protected]> Move rust installation further down for better flow Seems like build pipeline fails because we remove the osxcross directory, so might be better to concatenate the path and install rust a bit later. Signed-off-by: Alper Polat <[email protected]> Use rust image to add rcodesign instead of rustup Signed-off-by: Alper Polat <[email protected]> Copy from the correct directory Seems like the rcodesign binary ended up in `/usr/local/cargo` not /root... Signed-off-by: Alper Polat <[email protected]> Use `/usr/local/bin` instead Keep it simpler, we don't need the `cargo` directory. Signed-off-by: Alper Polat <[email protected]> Remove redundant space Signed-off-by: Alper Polat <[email protected]>
|
Should be good to go. I can look at improving the pipelines to add code signing next. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preparation for code signing OSX builds, will help fixing issues like prometheus/node_exporter#2539.
See https://github.com/indygreg/apple-platform-rs/tree/main/apple-codesign#rcodesign-cli for more info.