Add fallback scrape protocol to OTel collector #134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Arthur Silva Sens <[email protected]>
|
Does this mean everyone who updates will be broken unless they set this field? Can we not default that within the promethues receiver itself? |
|
After more research, it breaks any exporter that doesn't negotiate Content Type properly, as far as I understand. See comment prometheus/prometheus#15830 (comment) I'm not sure which side of the negotiation is at fault though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To unblock the compliance tests in open-telemetry/opentelemetry-collector-contrib#36873
cc @dashpole