model: Remove json-iterator usage (again) #453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@zenador as discussed. I believe, together with prometheus/client_golang#1225 , this should still work out in Mimir. To try it out, just make sure you have vendored in both PRs. |
roidelapluie
approved these changes
Feb 23, 2023
|
This needs a rebase to update the go.sum. |
This seemingly undoes #440, but all the json-iterator usage was actually pulled up into client_golang in prometheus/client_golang#1225 . Detailed explanation there. In short, we would like to keep heavy dependencies like json-iterator out of prometheus/common/model since many importers of this package aren't even interested in the JSON marshaling. Signed-off-by: beorn7 <[email protected]>
|
OK, rebased. I will only merge this once prometheus/client_golang#1225 is approved. |
kakkoyun
approved these changes
Mar 1, 2023
|
With prometheus/client_golang#1225 approved, I'll execute the following steps now:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This seemingly undoes #440, but all the json-iterator usage was actually pulled up into client_golang in
prometheus/client_golang#1225 . Detailed explanation there. In short, we would like to keep heavy dependencies like json-iterator out of prometheus/common/model since many importers of this package aren't even interested in the JSON marshaling.