Make it more efficient and compatible to use SampleHistogram #439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Store SampleHistogram in SampleHistogramPair as pointer. More compatible with what protobuf generates. More efficient when taking the histogram from the pair. Simpler test code. Signed-off-by: György Krajcsovits <[email protected]>
codesome
reviewed
Jan 26, 2023
| @@ -135,7 +135,7 @@ func (s *SampleHistogram) Equal(o *SampleHistogram) bool { | |||
|
|
|||
| type SampleHistogramPair struct { | |||
| Timestamp Time | |||
| Histogram SampleHistogram | |||
| Histogram *SampleHistogram | |||
There was a problem hiding this comment.
Worth commenting that it should never be nil and it is as a pointer for efficiency.
There was a problem hiding this comment.
should MarshalJSON check that it's nil and error out if it is?
There was a problem hiding this comment.
I've ended up convincing myself to error on nil histogram, to avoid ever generating invalid JSON from this
Signed-off-by: György Krajcsovits <[email protected]>
Signed-off-by: György Krajcsovits <[email protected]>
Signed-off-by: György Krajcsovits <[email protected]>
codesome
reviewed
Jan 26, 2023
Co-authored-by: Ganesh Vernekar <[email protected]> Signed-off-by: George Krajcsovits <[email protected]>
radek-ryckowski
pushed a commit
to goldmansachs/common
that referenced
this pull request
May 18, 2023
…eus#439) Store SampleHistogram in SampleHistogramPair as pointer. More compatible with what protobuf generates. More efficient when taking the histogram from the pair. Simpler test code. Signed-off-by: György Krajcsovits <[email protected]> Signed-off-by: George Krajcsovits <[email protected]> Co-authored-by: Ganesh Vernekar <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Store SampleHistogram in SampleHistogramPair as pointer.
More compatible with what protobuf generates.
More efficient when taking the histogram from the pair.
Simpler test code.
Signed-off-by: György Krajcsovits [email protected]