Add platform info to labels #403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have ping other people to get an opinion on this. |
juliusv
reviewed
Nov 3, 2022
juliusv
reviewed
Nov 3, 2022
lucacome
force-pushed
the
add-platform-info
branch
2 times, most recently
from
c9770e1 to
d4d71e3
Compare
|
Looks good to me. The tests seem to fail because of a problem upstream in prometheus/common. Maybe a rebase will help? |
|
yeah until either #407 or #410 go in the CI is going to fail. Looks like the only maintainer in the project is @roidelapluie ? |
lucacome
force-pushed
the
add-platform-info
branch
from
d4d71e3 to
ed3370a
Compare
juliusv
reviewed
Dec 7, 2022
|
Note that prometheus is already displaying this: |
Signed-off-by: Luca Comellini <[email protected]>
lucacome
force-pushed
the
add-platform-info
branch
from
ed3370a to
118bb72
Compare
|
Thanks! 👍 |
philipgough
added a commit
to philipgough/prometheus-operator
that referenced
this pull request
Dec 22, 2022
Test updated to reflect change in prometheus/common#403
radek-ryckowski
pushed a commit
to goldmansachs/common
that referenced
this pull request
May 18, 2023
Signed-off-by: Luca Comellini <[email protected]> Signed-off-by: Luca Comellini <[email protected]>
radek-ryckowski
pushed a commit
to goldmansachs/common
that referenced
this pull request
May 30, 2023
Signed-off-by: Luca Comellini <[email protected]> Signed-off-by: Luca Comellini <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the information about the platform to the list of labels