Disable HTTP/2 #249
Merged
Disable HTTP/2 #249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
How will the blackbox exporter turn it back on via this code? It doesn't do persistent connections, so those issues likely don't affect it. |
Signed-off-by: Julien Pivotto <[email protected]>
|
What about this? |
|
Let's not start hiding things in the YAML, we currently use function arguments for this - and the one that's there is already only used by blackbox. |
Signed-off-by: Julien Pivotto <[email protected]>
|
@brian-brazil I have adapted it. |
| err := http2.ConfigureTransport(rt.(*http.Transport)) | ||
| if err != nil { | ||
| return nil, err | ||
| if enableHTTP2 { |
There was a problem hiding this comment.
Can we add a comment that this should go away once Go is fixed?
There was a problem hiding this comment.
Actually if we add a comment, could we tight the disabling to the disableKeepAlives arg?
There was a problem hiding this comment.
In theory yes, but it feels pretty hacky.
Signed-off-by: Julien Pivotto <[email protected]>
|
I have put the golang issues in comment. |
roidelapluie
added a commit
to roidelapluie/alertmanager
that referenced
this pull request
Aug 14, 2020
- Disable HTTP2: prometheus/common#249 - Composite duration: prometheus/common#246 Signed-off-by: Julien Pivotto <[email protected]>
roidelapluie
added a commit
to roidelapluie/alertmanager
that referenced
this pull request
Aug 14, 2020
- Disable HTTP2: prometheus/common#249 - Composite duration: prometheus/common#246 Signed-off-by: Julien Pivotto <[email protected]>
simonpasquier
pushed a commit
to prometheus/alertmanager
that referenced
this pull request
Aug 25, 2020
- Disable HTTP2: prometheus/common#249 - Composite duration: prometheus/common#246 Signed-off-by: Julien Pivotto <[email protected]>
SuperQ
added a commit
to prometheus-community/json_exporter
that referenced
this pull request
Nov 2, 2020
* Update changelog * Bump Go modules. * Update NewClientFromConfig use prometheus/common#249 added option to disable HTTP/2. Signed-off-by: Ben Kochie <[email protected]>
SuperQ
added a commit
to prometheus-community/json_exporter
that referenced
this pull request
Nov 2, 2020
* Update changelog * Bump Go modules. * Update NewClientFromConfig use * Bump Go to 1.15. prometheus/common#249 added option to disable HTTP/2. Signed-off-by: Ben Kochie <[email protected]>
alanprot
pushed a commit
to alanprot/common
that referenced
this pull request
Mar 15, 2023
…ner-addr server: Expose `http` and `grpc` listen addresses.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HTTP/2 support is golang has many problematic cornercases where dead
connections would be kept.
golang/go#32388
golang/go#39337
golang/go#39750
I suggest we disable HTTP/2 for now and enable it manually on the
blackbox exporter.
Signed-off-by: Julien Pivotto [email protected]