Add unit to expect field in proto format, correct typo

Signed-off-by: Arianna Vespri <[email protected]>
prometheus · Feb 13, 2024 · 1755cb6 · 1755cb6
1 parent c1c06ad
commit 1755cb6
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 2 deletions.
diff --git a/expfmt/openmetrics_create.go b/expfmt/openmetrics_create.go
@@ -170,7 +170,7 @@ func MetricFamilyToOpenMetrics(out io.Writer, in *dto.MetricFamily, options ...T
 	if err != nil {
 		return
 	}
-	n, err = wwriteName(w, compliantName)
+	n, err = writeName(w, compliantName)
 	written += n
 	if err != nil {
 		return

diff --git a/model/metric.go b/model/metric.go
@@ -204,6 +204,7 @@ func EscapeMetricFamily(v *dto.MetricFamily, scheme EscapingScheme) *dto.MetricF
 	out := &dto.MetricFamily{
 		Help: v.Help,
 		Type: v.Type,
+		Unit: v.Unit,
 	}
 
 	// If the name is nil, copy as-is, don't try to escape.

diff --git a/model/metric_test.go b/model/metric_test.go
@@ -615,7 +615,7 @@ func TestProtoFormatUnchanged(t *testing.T) {
 		{
 			name:         "MetricFamily",
 			input:        &dto.MetricFamily{},
-			expectFields: []string{"name", "help", "type", "metric"},
+			expectFields: []string{"name", "help", "type", "metric", "unit"},
 		},
 		{
 			name:         "Metric",