Support metric help text in multiprocess mode #866
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue #211 Add support for storing the metrics help text in the multiprocess map. The help will come from the first process read, but it should be the same for all metrics. Signed-off-by: Cian Butler <[email protected]> Signed-off-by: Evgeny Markov <[email protected]>
Signed-off-by: Evgeny Markov <[email protected]>
|
See also: #866 |
|
I'll close my PR because it's exactly the same as #804 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello ✋🏻 I ran into a problem - open telemetry collector shows errors because I collect metrics with the same name from two applications - one single-process, the other multi-process:
label:<name:"path_template" value:"/api/rest/v1/auth/me" > label:<name:"project" value:"auth" > counter:<value:890 > has help "Total count of requests by method and path" but should have "Multiprocess metric"
Then I found old issue and I decided to fix it. @butlerx did almost all the work. I added only 1 test.