Change to imports to fix go-to-declaration in editors #747
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Angus Holder <[email protected]>
Signed-off-by: Angus Holder <[email protected]>
… the entrypoint of the library! Signed-off-by: Angus Holder <[email protected]>
angusholder
force-pushed
the
fix-go-to-declaration
branch
from
1c17c8c to
b6209f3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@csmarchbanks Just a small tweak to improve how prometheus_client behaves with IDEs/editors:
In PyCharm, when ctrl-clicking functions/classes of this library to go to their declaration, it takes me to
prometheus_client/__init__.pyinstead of where the function/class was actually defined. This seems to happen because__init__.pyuses assignments instead of imports to re-export members, so I've changed them all to imports.