Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check for negative counter-like and guage histogram values. #338

Merged
merged 1 commit into from
Nov 22, 2018
Merged

Check for negative counter-like and guage histogram values. #338

merged 1 commit into from
Nov 22, 2018

Conversation

brian-brazil
Copy link
Contributor

@SuperQ per the last two meetings.

SuperQ
SuperQ reviewed Nov 21, 2018
View reviewed changes
prometheus_client/openmetrics/parser.py Outdated
labelname = []
labelvalue = []
state = 'endoflabelvalue'
else:
else:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trailing spaces?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@SuperQ SuperQ self-requested a review November 21, 2018 13:32
SuperQ
SuperQ approved these changes Nov 21, 2018
View reviewed changes
Copy link
Member

@SuperQ SuperQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor issue with some trailing spaces, otherwise LGTM.

@brian-brazil brian-brazil merged commit 752c7bf into master Nov 22, 2018
@brian-brazil brian-brazil deleted the openmetrics branch November 22, 2018 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperQ SuperQ SuperQ approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brian-brazil @SuperQ