-
Notifications
You must be signed in to change notification settings - Fork 804
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support to jakarta servlet #647
Conversation
Signed-off-by: Nicolas Trangosi <[email protected]>
Signed-off-by: Nicolas Trangosi <[email protected]>
Thanks a lot. Do you see any way to reuse the existing code? For example, if we merge #639 the jakarta servlet will not have that change. |
I currently see no easy way to reuse the existing code. Changes from src dir are easy to report as the only changes are on import but for test directory it is not the case. |
… profile updateSource Signed-off-by: Nicolas Trangosi <[email protected]>
I have found a solution: This solution is not perfect as it may requires some adpations on test evolution and requires to modify first simpleclient_servlet, but it should do the job in a first time. |
Are there plans to merge this PR? Without this kinda change, we cannot upgrade to Jakarta and drop the old javax servlet API. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mmadoo sorry that it took so long to get back to this. Could you rebase it to the current master branch and squash the commits into one?
Hey, I just pushed a commit that replaces this one, so I'm closing it. The next release will have Jakarta support. The reason why I pushed my own commit is that I played with re-using code across both implementations (javax and jakarta), and I ended up having a quite complete solution. Thanks a lot for bringing this up, jakarta support is now on its way. |
Did this get released yet, @fstab ? |
never
|
The module simpleclient_servlet_jakarta is a copy of simpleclient_servlet where javax.servlet is replaced by jakarta.servlet (real changes can be seen in the second commit)