Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[prometheus-metrics-instrumentation-caffeine] implement getPrometheus… #1206

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[prometheus-metrics-instrumentation-caffeine] implement getPrometheus… #1206

wants to merge 1 commit into from
+68 −9

Conversation

pheyken
Copy link
Contributor

@pheyken pheyken commented Nov 15, 2024

…Names

Hey all, implementing this should have following benefits:

  • registering the CacheCollector twice will fail immediately and not when collecting metrics
  • avoid collecting metrics from the CacheCollector which would be discarded when a filter is passed to the PrometheusRegistry when scraping

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@pheyken