promhttp: Bite the bullet and implement all 32 possible interface combos #308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As it turned out, it's not that esay to guess "common" combination of interface upgrades. So I decided to just implement all 32 possible combination of interface upgrades. (Only 16 with Go 1.7 and earlier.) Clearly, this calls for code generation. But right now, we still need to find out what's the best form of the code. For later additions, implementing code generation might be useful. Note that newDelegator is called for each HTTP request. Thus, this commit aims to make the upgrade selection quick. (After the type checks, it's just directly accessing an element in a slice.)
|
Fixes #272. |
stuartnelson3
approved these changes
Jun 6, 2017
| id += readerFrom | ||
| } | ||
| if _, ok := w.(http.Pusher); ok { | ||
| id += pusher |
Yes, that's the idea: Minimize the overhead at runtime by having a lot of static code. What I did manually here is similar to things the C++ compiler does based on templates, so you can imagine where the infamous binary code bloat of C++ comes from. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@stuartnelson3 This is crazy…
As it turned out, it's not that esay to guess "common" combination of
interface upgrades. So I decided to just implement all 32 possible
combination of interface upgrades. (Only 16 with Go 1.7 and earlier.)
Clearly, this calls for code generation. But right now, we still need
to find out what's the best form of the code. For later additions,
implementing code generation might be useful.
Note that newDelegator is called for each HTTP request. Thus, this
commit aims to make the upgrade selection quick. (After the type
checks, it's just directly accessing an element in a slice.)