Bring back zero-alloc label-value access for metric vecs #226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 17, 2016 14:01
Also, fix mutex copy-by-value bug.
| return false | ||
| } | ||
|
|
||
| if len(metrics) > 1 { |
There was a problem hiding this comment.
If we really care about duplicated code, we could even move these 5 lines out in another function.
There was a problem hiding this comment.
True, but I guess it would not improve readability. So I better leave it as it is.
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, fix mutex copy-by-value bug.
Unfortunately, this did indeed require to duplicate a whole lot of code.
On the other hand, 117 additions and 89 deletions, not that bad... ;)
@grobie