Revert "Return error when TmplText errors in sns notifier" #3876
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 603a728.
|
@TheMeier this did break the tests - Let's revert it for now until I have some time to figure out what's wrong? |
grobinson-grafana
approved these changes
Jun 14, 2024
|
There are two imports for package sns
import (
"errors"
...
"github.com/pkg/errors"
)see 603a728. |
|
We should also replace |
|
My apologies for the previous PR, it was old and needed to be rebase. I have opened a new PR to fix the issue #3879 . Please have a look. Thank you. |
TheMeier
pushed a commit
to TheMeier/alertmanager
that referenced
this pull request
Sep 29, 2024
…#3531)" (prometheus#3876) This reverts commit 603a728.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #3531