chore: use Linux container CPU quota #3736
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uhthomas
force-pushed
the
3735
branch
2 times, most recently
from
5aed3cf to
0854af2
Compare
uhthomas
changed the title
uhthomas
force-pushed
the
3735
branch
2 times, most recently
from
76c626f to
3a05ee5
Compare
Go is not cgroup aware and by default will set GOMAXPROCS to the number of available threads, regardless of whether it is within the allocated quota. This behaviour causes high amount of CPU throttling and degraded application performance. Fixes: prometheus#3735 Signed-off-by: Thomas Way <[email protected]>
|
Can you make the output |
|
LGTM, but I would prefer to see this behind a flag |
D'oh stdout is the log, right? So basically just adapt the tests? |
|
Duplicate of #3837 |
Wrong link? You've just marked it as a duplicate of itself. |
|
Thanks, I have updated the link now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Go is not cgroup aware and by default will set GOMAXPROCS to the number of available threads, regardless of whether it is within the allocated quota. This behaviour causes high amount of CPU throttling and degraded application performance.
Fixes: #3735