Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.circleci/config.yml: disable test job requirement on publish #3484

Merged

Conversation

simonpasquier
Copy link
Member

The test job fails constantly on the release-0.25 branch. Skipping it to be able to publish v0.25.1.

The test job fails constantly on the release-0.25 branch. Skipping it to
be able to publish v0.25.1.

Signed-off-by: Simon Pasquier <[email protected]>
@simonpasquier simonpasquier requested a review from gotjosh August 24, 2023 08:14
Copy link
Member

@gotjosh gotjosh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment on lines +161 to +162
# don't make the test job a requirement because it fails constantly
# on release-0.25.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# don't make the test job a requirement because it fails constantly
# on release-0.25.
# don't make the test job a requirement because it fails constantly
# on release-0.25. Feel free to remove and fix it after 0.25.1 is published.

@simonpasquier simonpasquier merged commit c0a6992 into prometheus:release-0.25 Aug 24, 2023
@simonpasquier simonpasquier deleted the skip-test-job-for-publish branch August 24, 2023 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants