Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cluster: fix panic when tls_client_config is empty #3443

Merged
merged 1 commit into from
Aug 7, 2023

Conversation

simonpasquier
Copy link
Member

Closes #3403

Copy link
Member

@gotjosh gotjosh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

nice catch!

@simonpasquier
Copy link
Member Author

Note that I assumed that the TLS client configuration isn't required (though in most cases you probably want to provide the CA/cert/key). Feel free to correct me if I'm wrong :)

@simonpasquier simonpasquier merged commit 5626bd4 into prometheus:main Aug 7, 2023
1 check passed
@simonpasquier simonpasquier deleted the fix-panic branch August 7, 2023 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nil pointer derefernce when attempting to use the --cluster.tls-config arg
2 participants