-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Log the GroupKey and alerts in retry #3438
Merged
gotjosh
merged 1 commit into
prometheus:main
from
grobinson-grafana:grobinson/log-group-key-and-alerts-in-retry
Aug 7, 2023
Merged
Log the GroupKey and alerts in retry #3438
gotjosh
merged 1 commit into
prometheus:main
from
grobinson-grafana:grobinson/log-group-key-and-alerts-in-retry
Aug 7, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grobinson-grafana
force-pushed
the
grobinson/log-group-key-and-alerts-in-retry
branch
from
August 3, 2023 09:46
1be3f6b
to
d6a2b0d
Compare
simonpasquier
approved these changes
Aug 3, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
This commit updates notify.go to log the GroupKey and fingerprints of an alert at the debug level, and just the GroupKey at the warning level should the notify attempt fail. Signed-off-by: George Robinson <[email protected]>
gotjosh
force-pushed
the
grobinson/log-group-key-and-alerts-in-retry
branch
from
August 7, 2023 09:53
d6a2b0d
to
64cd8f3
Compare
Rebased to make sure CI passes. |
gotjosh
approved these changes
Aug 7, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thank you very much for your contribution. |
radek-ryckowski
pushed a commit
to goldmansachs/alertmanager
that referenced
this pull request
Nov 6, 2023
This commit updates notify.go to log the GroupKey and fingerprints of an alert at the debug level, and just the GroupKey at the warning level should the notify attempt fail. Signed-off-by: George Robinson <[email protected]>
qinxx108
pushed a commit
to amazon-contributing/alertmanager
that referenced
this pull request
Mar 28, 2024
This commit updates notify.go to log the GroupKey and fingerprints of an alert at the debug level, and just the GroupKey at the warning level should the notify attempt fail. Signed-off-by: George Robinson <[email protected]>
grobinson-grafana
deleted the
grobinson/log-group-key-and-alerts-in-retry
branch
April 16, 2024 14:44
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
This pull request updates
notify.go
to log the GroupKey and fingerprints of an alert at the debug level, and just the GroupKey at the warning level should the notify attempt fail.Here is an example of it at debug level:
and when notify attempt fails:
Motivation
Without this change it's almost impossible to correlate a
Notify success
log line with the aggregation group's flush log line, and vice versa. This change will make it easier to debug issues around missing notifications or unexpected notifications for alerts when running large Alertmanager installations with 10,000s of alerts.For example: