mark webhook URL as a secret #3228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Simon Rozet <[email protected]>
sr
force-pushed
the
webhook-secret-url
branch
from
774f7cc
to
6a5eed6
Compare
|
Any thoughts @simonpasquier? |
|
I don't feel strongly about it but we need to make it explicit in the CHANGELOG that the webhook's URL is now a secret value and that it won't show up in the Alertmanager's logs in clear. |
|
Should I update the changelog or will you take care of it? Also I still think #3223 is useful, for deployments where secrets are injected as files (e.g. secret volume in Kubernetes or systemd-creds) I will rebase that PR and add some more tests after this is merged. |
No, whoever is going to shepherd/review the next release should be vigilant. And yes #3223 is useful. |
I'll keep it in mind. |
hoperays
pushed a commit
to hoperays/alertmanager
that referenced
this pull request
Apr 23, 2023
Signed-off-by: Simon Rozet <[email protected]>
2 tasks
radek-ryckowski
pushed a commit
to goldmansachs/alertmanager
that referenced
this pull request
Nov 6, 2023
Signed-off-by: Simon Rozet <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #3223
/cc @gotjosh @simonpasquier