support loading pushover secrets from files #3200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add the user_key_file and token_file keys to the pushover config. /cc prometheus#2498 Signed-off-by: Simon Rozet <[email protected]>
Signed-off-by: Simon Rozet <[email protected]>
|
Huum the test failure looks like a flake? The previous commit passed: https://app.circleci.com/pipelines/github/prometheus/alertmanager/3232 |
yep, nothing to do with your change. |
Co-authored-by: Simon Pasquier <[email protected]> Signed-off-by: Simon Rozet <[email protected]>
Co-authored-by: Simon Pasquier <[email protected]> Signed-off-by: Simon Rozet <[email protected]>
|
Thanks for the review, I've committed your suggestions. |
|
Do I need to do something to move this forward? Rebase? |
|
sorry for the late reply!
I'm investigating why the tests are flaky which could be resolved by #3216 . I'll let you know if you need to rebase after the other PR gets merged :) |
|
Sweet, thanks for fixing those flakey tests @simonpasquier 🥂 |
hoperays
pushed a commit
to hoperays/alertmanager
that referenced
this pull request
Apr 23, 2023
* support loading pushover secrets from files Add the user_key_file and token_file keys to the pushover config. /cc prometheus#2498 Signed-off-by: Simon Rozet <[email protected]>
2 tasks
radek-ryckowski
pushed a commit
to goldmansachs/alertmanager
that referenced
this pull request
Nov 6, 2023
* support loading pushover secrets from files Add the user_key_file and token_file keys to the pushover config. /cc prometheus#2498 Signed-off-by: Simon Rozet <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the user_key_file and token_file keys to the pushover config.
/cc #2498
Signed-off-by: Simon Rozet [email protected]