Added note on data retention to documentation for repeat_interval #3147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I pushed one extra commit to address my own comment as this has been sitting for a while now. |
Signed-off-by: Soon-Ping Phang <[email protected]> Signed-off-by: Simon Pasquier <[email protected]>
Signed-off-by: gotjosh <[email protected]> Signed-off-by: Simon Pasquier <[email protected]>
simonpasquier
force-pushed
the
20221125-repeat_interval-retention-doc
branch
from
9d8c896
to
761b71f
Compare
hoperays
pushed a commit
to hoperays/alertmanager
that referenced
this pull request
Apr 23, 2023
…ometheus#3147) * Added note on data retention to documentation for repeat_interval Signed-off-by: Soon-Ping Phang <[email protected]> --------- Signed-off-by: Soon-Ping Phang <[email protected]>
radek-ryckowski
pushed a commit
to goldmansachs/alertmanager
that referenced
this pull request
Nov 6, 2023
…ometheus#3147) * Added note on data retention to documentation for repeat_interval Signed-off-by: Soon-Ping Phang <[email protected]> --------- Signed-off-by: Soon-Ping Phang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added an extra note to the documentation for repeat_interval regarding its relation to data retention.
Some projects that build on top of AlertManager (Cortex comes to mind) haven't ported over the change in #1993 , and so users/tenants are surprised when they see alerts being resent more frequently than expected.
In addition to the logging, it would be better to document up front the affect of data retention on alert resend behaviour (as suggested in #2934).
Signed-off-by: Soon-Ping Phang [email protected]