Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include status code label to the numTotalFailedNotifications for all notifiers #3231

Open
1 of 12 tasks
gotjosh opened this issue Jan 27, 2023 · 0 comments
Open
1 of 12 tasks

Include status code label to the numTotalFailedNotifications for all notifiers #3231

gotjosh opened this issue Jan 27, 2023 · 0 comments
Labels
component/notify help wanted kind/enhancement

Comments

@gotjosh
Copy link
Member

gotjosh commented Jan 27, 2023 •
edited
Loading

@gotjosh gotjosh mentioned this issue Jan 27, 2023
Merged
gotjosh added a commit that referenced this issue Feb 15, 2023
@gotjosh
add reason code to slack notifier
c9c307a 
this uses the new error with reason to determine based on status code what the reason is for the slack integration

partial #3231
@gotjosh gotjosh mentioned this issue Feb 15, 2023
Merged
gotjosh added a commit that referenced this issue Feb 15, 2023
@gotjosh
add reason code to slack notifier
c6b6ea8 
this uses the new error with reason to determine based on status code what the reason is for the slack integration

partial #3231

Signed-off-by: gotjosh <[email protected]>
gotjosh added a commit that referenced this issue Apr 28, 2023
@gotjosh
add reason code to slack notifier (#3252)
4dc2015 
* add reason code to slack notifier
this uses the new error with reason to determine based on status code what the reason is for the slack integration

partial #3231

Signed-off-by: gotjosh <[email protected]>

* Add some tests

Signed-off-by: gotjosh <[email protected]>

* Handle the error

Signed-off-by: gotjosh <[email protected]>

---------

Signed-off-by: gotjosh <[email protected]>
gotjosh added a commit that referenced this issue Aug 7, 2023
@gotjosh
add reason code to slack notifier (#3252)
2d22f2f 
* add reason code to slack notifier
this uses the new error with reason to determine based on status code what the reason is for the slack integration

partial #3231

Signed-off-by: gotjosh <[email protected]>

* Add some tests

Signed-off-by: gotjosh <[email protected]>

* Handle the error

Signed-off-by: gotjosh <[email protected]>

---------

Signed-off-by: gotjosh <[email protected]>
radek-ryckowski pushed a commit to goldmansachs/alertmanager that referenced this issue Nov 6, 2023
@gotjosh @radek-ryckowski
add reason code to slack notifier (prometheus#3252)
c428359 
* add reason code to slack notifier
this uses the new error with reason to determine based on status code what the reason is for the slack integration

partial prometheus#3231

Signed-off-by: gotjosh <[email protected]>

* Add some tests

Signed-off-by: gotjosh <[email protected]>

* Handle the error

Signed-off-by: gotjosh <[email protected]>

---------

Signed-off-by: gotjosh <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component/notify help wanted kind/enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@gotjosh