AKS - Create dedicated kubernetes service to expose CoreDNS metrics #2107
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently the kube-prometheus-stack creates a ServiceMonitor to collect the coredns metrics of a Kubernetes Service which is not exposing them. This is caused by the fact that AKS is not exposing the metrics port by default on the kube-dns service.
In order not to have to patch the service manually, I suggest the creation of a dedicated service in case that the platform is set to aks.
AKS kube-dns service definition:
Code section where we create the CoreDNS ServiceMonitor
kube-prometheus/jsonnet/kube-prometheus/components/k8s-control-plane.libsonnet
Line 315 in c9e1145
Type of change
What type of changes does your code introduce to the kube-prometheus? Put an
x
in the box that apply.CHANGE
(fix or feature that would cause existing functionality to not work as expected)FEATURE
(non-breaking change which adds functionality)BUGFIX
(non-breaking change which fixes an issue)ENHANCEMENT
(non-breaking change which improves existing functionality)NONE
(if none of the other choices apply. Example, tooling, build system, CI, docs, etc.)Changelog entry
Added kubernetes service creation for AKS platform to expose CoreDNS metrics