Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jsonnet: Update disk selector regex. #1945

Merged
merged 1 commit into from
Nov 23, 2022

Conversation

AshtonKem
Copy link
Contributor

Update regex used for selecting disk devices to include raid devices of the form "md123".

Description

My raid device is named "md127", which is not selected by the regexes currently used. This results in prometheus rules that would remain green even when the raid device is degraded.

This change adds "md.+" to the relevant regexes, to include these types of devices.

Type of change

What type of changes does your code introduce to the kube-prometheus? Put an x in the box that apply.

  • CHANGE (fix or feature that would cause existing functionality to not work as expected)
  • FEATURE (non-breaking change which adds functionality)
  • BUGFIX (non-breaking change which fixes an issue)
  • ENHANCEMENT (non-breaking change which improves existing functionality)
  • NONE (if none of the other choices apply. Example, tooling, build system, CI, docs, etc.)

Changelog entry

Please put a one-line changelog entry below. Later this will be copied to the changelog file.

Update regex used for selecting disk devices to include raid devices of the form "md123".

Update regex used for selecting disk devices to include raid devices of
the form "md123".
@philipgough philipgough merged commit e435c1d into prometheus-operator:main Nov 23, 2022
@AshtonKem AshtonKem deleted the raid-selector branch November 23, 2022 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants