prometheus-adapter: add prefix option to config for container metrics #1844
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jan--f
force-pushed
the
custom-pa-metrics
branch
from
b4e6edc
to
3e23e90
Compare
This commit adds the options `containerMetricsPrefix` to the prometheus-adapter config-map generator. By default this option is the empty string and doesn't change the current behavior. If set however to e.g. `pa_`, the prometheus-adapter configuration will add this prefix to all container_ queries in the resource rules. This enables users of kube-prometheus to define a specialised service monitor, that only expose the prometheus-adapter related container metrics with a different configuration, like `honorTimestamps: true` or a tighter scrape interval. Signed-off-by: Jan Fajerski <[email protected]>
jan--f
force-pushed
the
custom-pa-metrics
branch
from
3e23e90
to
38b74e4
Compare
jan--f
changed the title
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This commit adds the options
containerMetricsPrefixto the prometheus-adapter config-map generator. By default this option
is the empty string and doesn't change the current behavior. If set
however to e.g.
pa_, the prometheus-adapter configuration will addthis prefix to all container_ queries in the resource rules.
This enables users of kube-prometheus to define a specialised service
monitor, that only expose the prometheus-adapter related container metrics with a
different configuration, like
honorTimestamps: trueor a tighterscrape interval.
Type of change
CHANGE(fix or feature that would cause existing functionality to not work as expected)FEATURE(non-breaking change which adds functionality)BUGFIX(non-breaking change which fixes an issue)ENHANCEMENT(non-breaking change which improves existing functionality)NONE(if none of the other choices apply. Example, tooling, build system, CI, docs, etc.)Changelog entry
Please put a one-line changelog entry below. Later this will be copied to the changelog file.