Update kubeadm integration of kube-prometheus #1569
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In short, this PR fixes #1194
It was reported that kubeadm configuration advisory on this repository is very outdated; it uses
kubeadm.k8s.io/v1alpha1while the upstream is usingkubeadm.k8s.io/v1beta2and it has no compatibility with the current state.I addressed this by introducing the latest kubeadm config spec based on https://pkg.go.dev/k8s.io/kubernetes/cmd/kubeadm/app/apis/kubeadm/v1beta2 and each component's args, as well as removing cAdvisor section entirely as it is no longer required due to kubernetes/kubernetes#56523
Type of change
NONE(if none of the other choices apply. Example, tooling, build system, CI, docs, etc.)Changelog entry