jsonnet/node-exporter: adjust to node-exporter v1.2.0 arg name change #1407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In version [node-exporter v1.2.0](https://github.com/prometheus/node_exporter/releases/tag/v1.2.0) two argument name changes were introduced. While the old names still work (with a deprecation warning), lets use the new names. Signed-off-by: Jan Fajerski <[email protected]>
dgrisonnet
approved these changes
Sep 29, 2021
|
Now that we moved to automated component version update, I guess have been less careful about the changes introduced by each version so it would be great if we could attach the changelogs of the new versions to the PR that does the update. It would be easier to review the changes and prevent this kind of issue from occurring again in the future. |
5 tasks
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In version node-exporter v1.2.0
two argument name changes were introduced. While the old names still
work (with a deprecation warning), lets use the new names.
Signed-off-by: Jan Fajerski [email protected]
Description
Use
--collector.filesystem.mount-points-excludeinstead of deprecated--collector.filesystem.ignored-mount-pointsargument fornode-exporter.Type of change
CHANGE(fix or feature that would cause existing functionality to not work as expected)FEATURE(non-breaking change which adds functionality)BUGFIX(non-breaking change which fixes an issue)ENHANCEMENT(non-breaking change which improves existing functionality)NONE(if none of the other choices apply. Example, tooling, build system, CI, docs, etc.)Changelog entry