Skip to content
This repository has been archived by the owner on Aug 13, 2019. It is now read-only.

Seek() shouldn't return true when past maxt. Also add some tests to s… #327

Closed
wants to merge 2 commits into from

Conversation

free
Copy link
Contributor

@free free commented May 8, 2018

Seek() shouldn't return true when past maxt. Also add some tests to show that Querier.Select() may return series with no values.

Signed-off-by: Alin Sinpalean [email protected]

…how that Querier.Select may return series with no values.

Signed-off-by: Alin Sinpalean <[email protected]>
@free
Copy link
Contributor Author

free commented May 8, 2018

Was trying to add a SeekBefore() to find the first value before time t (which is what Seek() should do by default, I believe) and found a number of problems with the Seek() implementation.

This is one of the problems. The other is that Seek() will actually seek backwards within the same chunk which is (1) broken (even though never relied upon AFAICT) and (2) inefficient because it will start scanning from the beginning of the chunk. I'll address that separately.

@free
Copy link
Contributor Author

free commented May 9, 2018

Damned DCO. Closing because I forgot to add the signature to one of the commits.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant