BREAKING: Convert the process collector to use perflib #489
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinlindhe
approved these changes
Mar 25, 2020
|
Thanks @carlpett! Just curious when do we expect to be released? |
|
@YangLu1031 I think it would be nice to get a couple of the larger changes in at the same time so we don't need so many releases with breaking changes, but: soon. |
|
@carlpett I see, thanks! And how to create our own .msi file including this change? |
This was referenced Apr 3, 2020
anubhavg-icpl
pushed a commit
to anubhavg-icpl/windows_exporter
that referenced
this pull request
Sep 22, 2024
…-perflib BREAKING: Convert the process collector to use perflib
anubhavg-icpl
pushed a commit
to anubhavg-icpl/windows_exporter
that referenced
this pull request
Sep 22, 2024
…munity#497) With PR prometheus-community#489 `--collector.process.processes-where` no longer works, changing example to use `--collector.process.whitelist` with regexp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR converts the process collector to use perflib rather than WMI. Without filters, it speeds up collection on my machine by 10-50x.
However, since the current implementation has filtering based on WQL, which we cannot support for perflib, this is a breaking change. I changed the flags to match what we have in eg
logical_disk, with regexp white/blacklists.