Abort scrapes after configurable timeout #340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinlindhe
approved these changes
Jun 23, 2019
martinlindhe
requested changes
Jun 23, 2019
martinlindhe
approved these changes
Jun 25, 2019
carlpett
changed the title
|
Merging this (but note that it merges into the perflib-cpu branch, not master) |
anubhavg-icpl
pushed a commit
to anubhavg-icpl/windows_exporter
that referenced
this pull request
Sep 22, 2024
…-scrapes Abort scrapes after configurable timeout
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #335.
This implements a rough abort after a timeout, so the scrape can return even if WMI has hung for some collectors (eg #89, #270).
I'm not super happy about the implementation, it feels like a mess of interleaved goroutines that are not easy to understand. Tried a few variations of using the normal
context, but it also had a lot of them.Happy for suggestions. Maybe the main
Collectfunction should be rewritten.