fix mssql for non-default sql instances #237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
work in progress until the |
|
#236 is merged! |
|
LGTM, anything apart from rebase needed? |
the only sql servers I have access to are using the default `MSSQLSERVER` instance names. I was contacted by someone using a different instance name and it was failing. Found 2 bugs in the code: 1) I was returning the default `MSSQLSERVER` as an instance even if it wasn't found in the registry 2) learned that the WMI class naming scheme for non-default instances was not what I had coded. Changed to incorproate new knowledge.
|
I'm also working offline with @sysadmind to see if this, indeed, works. |
szook
changed the title
|
got confirmation that this works. Removed WIP |
|
Thanks! Cutting a new release in a few minutes |
anubhavg-icpl
pushed a commit
to anubhavg-icpl/windows_exporter
that referenced
this pull request
Sep 22, 2024
…non-default-instances fix mssql for non-default sql instances
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the only sql servers I have access to are using the default
MSSQLSERVERinstance names. I was contacted by someone using adifferent instance name and it was failing.
Found 2 bugs in the code:
I was returning the default
MSSQLSERVERas an instance even if it wasn't found in the registrylearned that the WMI class naming scheme for non-default instances
was not what I had coded. Changed to incorproate new knowledge.