logon: BREAKING: replace wmi query by Win32 API calls and expose detailed logon sessions. (click PR for more information) #1687
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reworks the logon collector.
It replaces the slow WMI query with Win32 API syscalls. Instead expose the amount of session types, each logon session is exposes.
The
windows_logon_logon_type
metric as been replaced bywindows_logon_session_logon_timestamp_seconds
.The
windows_logon_session_logon_timestamp_seconds
metric hold each single session on each system. As value, the logon time is used. Username and Domain name is exposed as well.The
status
label fromwindows_logon_logon_type
metric has been renamed totype
and matches the case from the Windows documentation.remote_interactive
->RemoteInteractive
If running as SYSTEM user, system session will be exposed as well.
The collect time has been reduced by 90%+
Old metrics
New metrics