Skip to content

performancecounter: support yaml documents and tolerate collector errors #1512

performancecounter: support yaml documents and tolerate collector errors

performancecounter: support yaml documents and tolerate collector errors #1512

Triggered via pull request December 9, 2024 00:09
Status Failure
Total duration 4m 14s
Artifacts 1

lint.yml

on: pull_request
Fit to window
Zoom out
Zoom in

Annotations

9 errors
lint: internal/collector/performancecounter/performancecounter.go#L132
fmt.Errorf can be replaced with errors.New (perfsprint)
lint: internal/collector/performancecounter/performancecounter.go#L150
ranges should only be cuddled with assignments used in the iteration (wsl)
lint: internal/collector/performancecounter/performancecounter.go#L217
SA4010: this result of append is never used, except maybe in other appends (staticcheck)
lint: internal/collector/performancecounter/performancecounter.go#L257
SA4010: this result of append is never used, except maybe in other appends (staticcheck)
lint: internal/collector/performancecounter/performancecounter_test_test.go#L147
only one cuddle assignment allowed before if statement (wsl)
lint: internal/collector/performancecounter/types.go#L21
tag is not aligned, should be: json:"name" yaml:"name" (tagalign)
lint: pkg/collector/collect.go#L209
if statements should only be cuddled with assignments used in the if statement itself (wsl)
lint
issues found
test
Process completed with exit code 1.

Artifacts

Produced during runtime
Name Size
windows_exporter.amd64.exe
11.6 MB