-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fill missing metrics labels with empty string to avoid label dimensions inconsistent failure #23
Fill missing metrics labels with empty string to avoid label dimensions inconsistent failure #23
Conversation
I tested your branch, but it still gives me:
using the following metrics:
|
have you used a new flag which enables the fix? |
Oops, I might have missed the Will test again next week... |
Thanks for the patch! It seems to work almost perfectly, but not quite. We're still seeing sporadic errors for some metrics from On the other hand, the issues we saw before applying your changes were also about loadbalancing metrics, so I'm not 100% sure if it made much of a difference. We have set Perhaps the remaining issues have something to do with histograms, specifically?
|
I checked the histograms and everything seems to be working as expected (assuming that the mentioned metric is always DISTRIBUTION - as it should be due to https://cloud.google.com/monitoring/api/metrics_gcp#gcp-loadbalancing) Could you build in some traces and provide some raw data for "stackdriver_https_lb_rule_loadbalancing_googleapis_com_https_total_latencies" ? |
After enabling the fill missing flag, I still get some errors, although much less than before. I also hit some rate limits. We have quite a few topics. Would it help to run in debug log level for some time?
|
To get a sense of what is failing the most (logs from 25. May to 28 of June):
|
It just struck me that these are 503s we are getting from the Google APIs. Not 503s from stackdriver_exporter... |
I have used this branch in production many months now, and it looks ok. |
The PR fixes #19 by adding missing labels keys with empty string values.
The feature (fix) is enabled with "collector.fill-missing-labels" flag.