Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add TLS support for metrics #68

Merged
merged 1 commit into from
Dec 14, 2020
Merged

Add TLS support for metrics #68

merged 1 commit into from
Dec 14, 2020

Conversation

dmaganto
Copy link
Contributor

@dmaganto dmaganto commented Dec 3, 2020

Add TLS support for metrics

@SuperQ
Copy link
Contributor

SuperQ commented Dec 4, 2020

This needs to use https://github.com/prometheus/exporter-toolkit https package to maintain consistency across exporter projects.

@dmaganto
Copy link
Contributor Author

dmaganto commented Dec 4, 2020

New commit, using https://github.com/prometheus/exporter-toolkit to maintain consistency across exporter projects.

SuperQ
SuperQ reviewed Dec 9, 2020
View reviewed changes
cmd/main.go Outdated Show resolved Hide resolved
@dmaganto
Copy link
Contributor Author

dmaganto commented Dec 9, 2020

Hi @SuperQ, sorry, I was do as node_exporter repository, that integrate https in it. I fix in the current commit. Regards

@SuperQ
Copy link
Contributor

SuperQ commented Dec 9, 2020

No worries, the node_exporter was where we started the https experiment. It's on the TODO list to switch it over to the exporter-toolkit version.

SuperQ
SuperQ approved these changes Dec 9, 2020
View reviewed changes
Copy link
Contributor

@SuperQ SuperQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks!

@SuperQ SuperQ requested a review from roidelapluie December 9, 2020 15:52
@rustycl0ck
Copy link
Member

@dmaganto , can you add documentation too (a sample config or a link to the config file format for using this feature)

@SuperQ
Copy link
Contributor

SuperQ commented Dec 9, 2020

Rather than reproduce the docs here, how about we add a link to the https README in the exporter toolkit from this repo's README.

@dmaganto
Copy link
Contributor Author

dmaganto commented Dec 9, 2020 •
edited
Loading

@rustycl0ck @SuperQ Added sample documentation about how use /metrics through TLS. Regards

SuperQ
SuperQ reviewed Dec 10, 2020
View reviewed changes
test/tls/server.crt Outdated Show resolved Hide resolved
SuperQ
SuperQ reviewed Dec 10, 2020
View reviewed changes
test/tls/web-config.yml Outdated Show resolved Hide resolved
SuperQ
SuperQ reviewed Dec 10, 2020
View reviewed changes
README.md Outdated Show resolved Hide resolved
SuperQ
SuperQ reviewed Dec 10, 2020
View reviewed changes
README.md Outdated Show resolved Hide resolved
@dmaganto
Add TLS metrics support
bffc119 
Signed-off-by: Daniel Maganto <[email protected]>
@SuperQ
Copy link
Contributor

SuperQ commented Dec 10, 2020

Nice, thanks for implementing this.

@SuperQ SuperQ requested a review from rustycl0ck December 10, 2020 17:31
rustycl0ck
rustycl0ck approved these changes Dec 11, 2020
View reviewed changes
Copy link
Member

@rustycl0ck rustycl0ck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇

@SuperQ SuperQ merged commit f54aa70 into prometheus-community:master Dec 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperQ SuperQ SuperQ approved these changes

@rustycl0ck rustycl0ck rustycl0ck approved these changes

@roidelapluie roidelapluie Awaiting requested review from roidelapluie

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dmaganto @SuperQ @rustycl0ck