Add functionality to add headers to the request #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vincent Cui <[email protected]>
* Update the example config to use `headers` as well as the `metrics` keys in alignment with the new code
* Change the header config from a list to a map.
From:
```
headers:
- X-Dummy: my-header
- X-Test: another-header
```
To:
```
headers:
X-Dummy: my-header
X-Test: another-header
```
* Fix the bug where the new header feature wasn't working because of passing wrong pointers
Signed-off-by: rustyclock <[email protected]>
Signed-off-by: rustyclock <[email protected]>
|
This is ready for review @SuperQ, @roidelapluie |
|
Close this in favor of #49 which already includes the changes/fixes from this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #30 with following changes:
headersas well as themetricskeys in alignment with the new codeFrom:
Accept: application/json