[prometheus-node-exporter] Allow to opt-out node exporter rootfs mount #756
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mes it cannot be mounted) Signed-off-by: Davide Giacomini <[email protected]>
Signed-off-by: Davide Giacomini <[email protected]>
davgia
requested review from
bismarck,
gianrubio and
vsliouniaev
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Allows to opt-out the node-exporter deamonset mount of
/from the host. This is necessary because it's not always possible to do it. To avoid changing the current behaviour of the chart the defaul value is set totrue.N.B.
Another PR (no. 737) with similar changes has already been merged, but it did not modify all required charts.
Which issue this PR fixes
#467
Special notes for your reviewer:
Checklist
[prometheus-couchdb-exporter])