-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[kube-prometheus-stack] support kubelet endpoint slices #4899
base: main
Are you sure you want to change the base?
Changes from 1 commit
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -103,7 +103,10 @@ rules: | |
- endpointslices | ||
verbs: | ||
- get | ||
- create | ||
- list | ||
- watch | ||
- update | ||
- delete | ||
{{- end }} | ||
{{- end }} |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -63,6 +63,12 @@ spec: | |
- --kubelet-selector={{ .Values.prometheusOperator.kubeletService.selector }} | ||
{{- end }} | ||
{{- end }} | ||
{{- if .Values.prometheusOperator.kubeletEndpointsEnabled }} | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. if in combination with an boolean might be mis-leading. Since not sure, if
would help here, since it converts the value to a string and There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Good point, maybe just omit the ifs entirely and go by the values.yaml values? |
||
- --kubelet-endpoints={{ .Values.prometheusOperator.kubeletEndpointsEnabled }} | ||
{{- end }} | ||
{{- if .Values.prometheusOperator.kubeletEndpointSliceEnabled }} | ||
- --kubelet-endpointslice={{ .Values.prometheusOperator.kubeletEndpointSliceEnabled }} | ||
{{- end }} | ||
{{- if .Values.prometheusOperator.logFormat }} | ||
- --log-format={{ .Values.prometheusOperator.logFormat }} | ||
{{- end }} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ideally we can use the
kubeletEndpointsEnabled
andkubeletEndpointSliceEnabled
to toggle granting these permissions. will let reviewer decide. i can add this logic if neededThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The toggle would cover only write permissions, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, I think all of the endpointslice permissions. unelss there is a reason not to (I dont see one)