Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[prometheus-postgres-exporter] Add zanhsieh as maintainer #47

Closed

Conversation

zanhsieh
Copy link
Contributor

@zanhsieh zanhsieh commented Sep 6, 2020

Signed-off-by: zanhsieh [email protected]

I would like to volunteer as co-maintainer of prometheus-postgres-exporter as:

#21

I currently am one of the maintainer of prometheus chart:

Copy link
Member

@scottrigby scottrigby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll also want to wait a bit for @gianrubio. Though I haven't heard replies from him for a while and he hasn't yet accepted the request to be part of this repo.

Related: we need to define the process (in PROCESSES doc) for what to do if chart maintainers are unreachable for some specified period of time.

@zanhsieh zanhsieh requested a review from a team as a code owner September 7, 2020 14:43
@zanhsieh
Copy link
Contributor Author

zanhsieh commented Sep 7, 2020

@scottrigby
When I change .github/CODEOWNERS, Github keeps complaining conflicting file .github/CODEOWNERS. What do I do wrong?

@torstenwalter
Copy link
Member

Did you try merging main branch into yours? As alternative you could do git checkout main .github/CODEOWNERS make the change you want and commit that.

@scottrigby
Copy link
Member

PS I heard from @gianrubio 🙂 so after fixing merge conflicts (as @torstenwalter said merge main), let's wait for Giancarlo's approval

… github.com:prometheus-community/helm-charts into zanhsieh-prometheus-postgres-exporter-promote-owner
.github/CODEOWNERS Outdated Show resolved Hide resolved
Signed-off-by: zanhsieh <[email protected]>
… github.com:prometheus-community/helm-charts into zanhsieh-prometheus-postgres-exporter-promote-owner
… github.com:prometheus-community/helm-charts into zanhsieh-prometheus-postgres-exporter-promote-owner

Signed-off-by: zanhsieh <[email protected]>
… github.com:prometheus-community/helm-charts into zanhsieh-prometheus-postgres-exporter-promote-owner
@gianrubio
Copy link
Contributor

There's a conflict with the CODEOWNER file, @zanhsieh please rebase your branch and see if it help. Other than that I'm fine by adding you as a maintainer

@zanhsieh
Copy link
Contributor Author

zanhsieh commented Sep 9, 2020

Close this since some rebase issue.

@zanhsieh zanhsieh closed this Sep 9, 2020
@zanhsieh zanhsieh deleted the zanhsieh-prometheus-postgres-exporter-promote-owner branch November 18, 2020 12:46
nf-npieros pushed a commit to nf-npieros/helm-charts that referenced this pull request Jan 17, 2022
nf-npieros pushed a commit to nf-npieros/helm-charts that referenced this pull request Jan 17, 2022
junotx pushed a commit to junotx/prometheus-helm-charts that referenced this pull request Mar 1, 2024
…etheus-stack

fix the bug where metrics kube_node_role do not exist
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants