Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[kube-prometheus-stack] update kps to v0.65.1 #3267

Closed
wants to merge 15 commits into from
Closed

[kube-prometheus-stack] update kps to v0.65.1 #3267

Show file tree
Hide file tree
Changes from 10 commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
c108a24
update kps to v0.64.0
QuentinBisson Apr 20, 2023
1c25302
adjust rbac
QuentinBisson Apr 20, 2023
082861b
[kube-prometheus-stack] Move CRD installation/upgrade to a job
QuentinBisson Apr 24, 2023
bee0f0c
Merge branch 'main' into kps64
QuentinBisson Apr 24, 2023
704b130
Move crd list to values
QuentinBisson Apr 24, 2023
1df5812
Make crds source url prefix configurable
QuentinBisson Apr 24, 2023
b4bebb5
Bump prometheus-operator to 0.64.1
QuentinBisson Apr 26, 2023
ddc4d29
Merge branch 'main' into kps64
QuentinBisson Apr 26, 2023
e2c3dd2
Upgrade to 0.65.1
QuentinBisson May 9, 2023
a153307
Merge branch 'main' into kps64
QuentinBisson May 9, 2023
4bb8ba0
Update readme
QuentinBisson May 9, 2023
32faf24
Merge branch 'main' into kps64
QuentinBisson May 9, 2023
ab473df
Merge branch 'main' into kps64
QuentinBisson May 9, 2023
98b5b05
add default security profile
QuentinBisson May 16, 2023
7d2c5cf
Merge branch 'main' into kps64
QuentinBisson May 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion charts/kube-prometheus-stack/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ name: kube-prometheus-stack
sources:
- https://github.com/prometheus-community/helm-charts
- https://github.com/prometheus-operator/kube-prometheus
version: 45.26.0
version: 46.0.0
appVersion: v0.65.1
kubeVersion: ">=1.16.0-0"
home: https://github.com/prometheus-operator/kube-prometheus
Expand Down
25 changes: 24 additions & 1 deletion charts/kube-prometheus-stack/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,8 +59,10 @@ kubectl delete crd alertmanagerconfigs.monitoring.coreos.com
kubectl delete crd alertmanagers.monitoring.coreos.com
kubectl delete crd podmonitors.monitoring.coreos.com
kubectl delete crd probes.monitoring.coreos.com
kubectl delete crd prometheusagents.monitoring.coreos.com
kubectl delete crd prometheuses.monitoring.coreos.com
kubectl delete crd prometheusrules.monitoring.coreos.com
kubectl delete crd scrapeconfigs.monitoring.coreos.com
kubectl delete crd servicemonitors.monitoring.coreos.com
kubectl delete crd thanosrulers.monitoring.coreos.com
```
Expand All @@ -80,9 +82,30 @@ _See [helm upgrade](https://helm.sh/docs/helm/helm_upgrade/) for command documen

A major chart version change (like v1.2.3 -> v2.0.0) indicates that there is an incompatible breaking change needing manual actions.

### From 45.x to 46.x

This version upgrades Prometheus-Operator to v0.65.1 with new CRDs (PrometheusAgent and ScrapeConfig), Prometheus to v2.43.1 and Thanos to v0.31.0.

As of this release, CRD installation and upgrade is now managed by the chart if the property `crds.enabled` is set to true (by default).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is confusing because CRD installation and upgrade is already managed by this chart before the change.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you also check for the existing helm property skipCrds (can you even do that?). If you can't do that you should mention that users of skipCRD need to migrate to .Values.crds.enabled. Otherwise users that already don't install the CRDs using this chart might suddenly have their CRDs managed by the chart by accident.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now I realize that changelogs need to be read carefully especially when it concerns a breaking change however the breaking change churn on this chart is so large that I can imagine that users might be a bit changelog-fatigued when it comes to this chart.


If you want to upgrade the CRDs the old fashion way, set `crds.enabled` to false and run these commands to update the CRDs before applying the upgrade.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps link to the CRDs chart instead?


```console
kubectl apply --server-side -f https://raw.githubusercontent.com/prometheus-operator/prometheus-operator/v0.65.1/example/prometheus-operator-crd/monitoring.coreos.com_alertmanagerconfigs.yaml
kubectl apply --server-side -f https://raw.githubusercontent.com/prometheus-operator/prometheus-operator/v0.65.1/example/prometheus-operator-crd/monitoring.coreos.com_alertmanagers.yaml
kubectl apply --server-side -f https://raw.githubusercontent.com/prometheus-operator/prometheus-operator/v0.65.1/example/prometheus-operator-crd/monitoring.coreos.com_podmonitors.yaml
kubectl apply --server-side -f https://raw.githubusercontent.com/prometheus-operator/prometheus-operator/v0.65.1/example/prometheus-operator-crd/monitoring.coreos.com_probes.yaml
kubectl apply --server-side -f https://raw.githubusercontent.com/prometheus-operator/prometheus-operator/v0.65.1/example/prometheus-operator-crd/monitoring.coreos.com_prometheusagents.yaml
kubectl apply --server-side -f https://raw.githubusercontent.com/prometheus-operator/prometheus-operator/v0.65.1/example/prometheus-operator-crd/monitoring.coreos.com_prometheuses.yaml
kubectl apply --server-side -f https://raw.githubusercontent.com/prometheus-operator/prometheus-operator/v0.65.1/example/prometheus-operator-crd/monitoring.coreos.com_prometheusrules.yaml
kubectl apply --server-side -f https://raw.githubusercontent.com/prometheus-operator/prometheus-operator/v0.65.1/example/prometheus-operator-crd/monitoring.coreos.com_scrapeconfigs.yaml
kubectl apply --server-side -f https://raw.githubusercontent.com/prometheus-operator/prometheus-operator/v0.65.1/example/prometheus-operator-crd/monitoring.coreos.com_servicemonitors.yaml
kubectl apply --server-side -f https://raw.githubusercontent.com/prometheus-operator/prometheus-operator/v0.65.1/example/prometheus-operator-crd/monitoring.coreos.com_thanosrulers.yaml
```

### From 44.x to 45.x

This version upgrades Prometheus-Operator to v0.63.0, Prometheus to v2.43.0 and Thanos to v0.30.2.
This version upgrades Prometheus-Operator to v0.63.0, Prometheus to v2.42.0 and Thanos to v0.30.2.

Run these commands to update the CRDs before applying the upgrade.

Expand Down
4,481 changes: 0 additions & 4,481 deletions charts/kube-prometheus-stack/crds/crd-alertmanagerconfigs.yaml
View file
Open in desktop

This file was deleted.

7,112 changes: 0 additions & 7,112 deletions charts/kube-prometheus-stack/crds/crd-alertmanagers.yaml
View file
Open in desktop

This file was deleted.

666 changes: 0 additions & 666 deletions charts/kube-prometheus-stack/crds/crd-podmonitors.yaml
View file
Open in desktop

This file was deleted.

705 changes: 0 additions & 705 deletions charts/kube-prometheus-stack/crds/crd-probes.yaml
View file
Open in desktop

This file was deleted.

9,177 changes: 0 additions & 9,177 deletions charts/kube-prometheus-stack/crds/crd-prometheuses.yaml
View file
Open in desktop

This file was deleted.

120 changes: 0 additions & 120 deletions charts/kube-prometheus-stack/crds/crd-prometheusrules.yaml
View file
Open in desktop

This file was deleted.

Loading