[kube-prometheus-stack] Expose the container-specific security context for Prometheus Operator #1811
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 18, 2022 11:52
…s operator Signed-off-by: rd5 <[email protected]>
Signed-off-by: rd5 <[email protected]>
rdauncey53
requested review from
andrewgkew,
bismarck,
desaintmartin,
gianrubio,
gkarthiks,
scottrigby and
Xtigyro
as code owners
monotek
requested changes
Feb 18, 2022
Signed-off-by: rd5 <[email protected]>
monotek
previously approved these changes
Feb 18, 2022
Signed-off-by: rd5 <[email protected]>
|
(28/2/2022 Fixed some merge conflicts) |
monotek
approved these changes
Feb 28, 2022
stamzid
pushed a commit
to Unstructured-IO/prometheus-community-helm-charts
that referenced
this pull request
Mar 3, 2023
…t for Prometheus Operator (prometheus-community#1811) * Expose the container-specific security context settings for Prometheus operator Signed-off-by: rd5 <[email protected]> * Bump kube-prometheus-stack chart version to 32.2.2 Signed-off-by: rd5 <[email protected]> * New feature so raise minor version to 32.3.0 Signed-off-by: rd5 <[email protected]> Co-authored-by: rd5 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
We want to further configure the Kubernetes container security context for the Prometheus Operator, so we can set other container-specific settings such as capabilities -> drop -> ALL. Therefore we expose the container-specific security context using
containerSecurityContextas the input (as used in other prometheus helm-charts e.g. node-exporter).Special notes for your reviewer:
We understand that some other Prometheus containers such as the node-exporter do not support dropping capabilities (in that case, because it did not have any in the first place) - this pull request assumes that isn't the case for Prometheus Operator, but please do let us know if that is an incorrect assumption.
Checklist
[prometheus-couchdb-exporter])