Skip to content

Commit

Permalink
json-exporter, make liveness and readiness probes fully configurable (#…
Browse files Browse the repository at this point in the history
…4909)

This changes makes both probes fully configurable, e.g. you are now able
to override timeoutSeconds and other settings.

Signed-off-by: Stefan Andres <[email protected]>
  • Loading branch information
stefanandres authored Oct 13, 2024
1 parent 05fcb4c commit 0529c10
Show file tree
Hide file tree
Showing 4 changed files with 19 additions and 9 deletions.
2 changes: 1 addition & 1 deletion charts/prometheus-json-exporter/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ type: application
# This is the chart version. This version number should be incremented each time you make changes
# to the chart and its templates, including the app version.
# Versions are expected to follow Semantic Versioning (https://semver.org/)
version: 0.13.0
version: 0.14.0

# This is the version number of the application being deployed. This version number should be
# incremented each time you make changes to the application. Versions are not expected to
Expand Down
3 changes: 3 additions & 0 deletions charts/prometheus-json-exporter/ci/default-values.yaml
Original file line number Diff line number Diff line change
@@ -1,2 +1,5 @@
deploymentAnnotations:
test-annotation: "true"

livenessProbe:
timeoutSeconds: 5
14 changes: 6 additions & 8 deletions charts/prometheus-json-exporter/templates/deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -59,14 +59,12 @@ spec:
- name: http
containerPort: 7979
protocol: TCP
livenessProbe:
httpGet:
path: /metrics
port: http
readinessProbe:
httpGet:
path: /metrics
port: http
{{- with .Values.livenessProbe }}
livenessProbe: {{- toYaml . | nindent 12 }}
{{- end }}
{{- with .Values.readinessProbe }}
readinessProbe: {{- toYaml . | nindent 12 }}
{{- end }}
resources:
{{- toYaml .Values.resources | nindent 12 }}
volumeMounts:
Expand Down
9 changes: 9 additions & 0 deletions charts/prometheus-json-exporter/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,15 @@ securityContext: {}
# runAsNonRoot: true
# runAsUser: 1000

livenessProbe:
httpGet:
path: /metrics
port: http
readinessProbe:
httpGet:
path: /metrics
port: http

service:
type: ClusterIP
port: 7979
Expand Down

0 comments on commit 0529c10

Please sign in to comment.