Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use ansible_facts instead of ansible_* variables #474

Merged
merged 1 commit into from
Jan 13, 2025
Merged

fix: use ansible_facts instead of ansible_* variables #474

merged 1 commit into from
Jan 13, 2025

Conversation

kleini
Copy link
Contributor

@kleini kleini commented Nov 21, 2024

to allow ANSIBLE_INJECT_FACT_VARS to become false.

fixes #297

@kleini kleini force-pushed the ansible-inject-fact-vars branch from 5056013 to 9691f17 Compare November 21, 2024 14:34
@github-actions github-actions bot added bugfix and removed bugfix labels Nov 21, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 21, 2024 •
edited
Loading

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and the docs are now incorporated into main:
https://prometheus-community.github.io/ansible/branch/main

@kleini kleini force-pushed the ansible-inject-fact-vars branch from ba5a95c to 70f4b04 Compare November 28, 2024 09:26
@github-actions github-actions bot added bugfix and removed bugfix labels Nov 28, 2024
@kleini kleini force-pushed the ansible-inject-fact-vars branch from 70f4b04 to 904c929 Compare November 28, 2024 10:35
@github-actions github-actions bot added bugfix and removed bugfix labels Nov 28, 2024
@kleini kleini force-pushed the ansible-inject-fact-vars branch from 904c929 to dd96c89 Compare November 28, 2024 10:51
@github-actions github-actions bot added bugfix and removed bugfix labels Nov 28, 2024
@kleini kleini force-pushed the ansible-inject-fact-vars branch 2 times, most recently from f82c52c to e5b1f6a Compare November 28, 2024 10:53
@github-actions github-actions bot added bugfix and removed bugfix labels Nov 28, 2024
@kleini
Copy link
Contributor Author

kleini commented Nov 28, 2024

I have no idea about the failing fail2ban roles. This seems to be broken in every pull request. Can somebody give me a hint, how to fix that? Or can this be fixed on the main branch?

@mgariepy
Copy link

I have no idea about the failing fail2ban roles. This seems to be broken in every pull request. Can somebody give me a hint, how to fix that? Or can this be fixed on the main branch?

seems like 308 error are not handled in fail2ban check prior to version 3.11.0 python version

python/cpython@c379bc5

@kleini
Copy link
Contributor Author

kleini commented Dec 2, 2024

If that is only fixed in Python 3.11, tests for Ansible <2.14 can not be fixed as they do not support that new Python version.

@mgariepy
Copy link

mgariepy commented Dec 2, 2024

If that is only fixed in Python 3.11, tests for Ansible <2.14 can not be fixed as they do not support that new Python version.

the 308 redirect is kinda new, since it seems only to be done for fail2ban 0.10.2 released on November 20th.

downloading the release 0.10.1 checksums only goes through a 301.

@mgariepy mgariepy mentioned this pull request Dec 2, 2024
Merged
@mgariepy
Copy link

mgariepy commented Dec 4, 2024 •
edited
Loading

I added a post in gitlab's forum, after some investigation the issue seems to be a double "/" in a 302 that leads to a 308 on the gitlab side.

@mgariepy
Copy link

mgariepy commented Dec 5, 2024

here is the link to the gitlab issue : https://gitlab.com/gitlab-org/gitlab/-/issues/508161

@kleini
Use variables from ansible_facts
066188f 
to allow ANSIBLE_INJECT_FACT_VARS to become false

Signed-off-by: Marcus Klein <[email protected]>
@kleini kleini force-pushed the ansible-inject-fact-vars branch from e5b1f6a to 066188f Compare January 13, 2025 08:18
@github-actions github-actions bot added bugfix and removed bugfix labels Jan 13, 2025
@kleini
Copy link
Contributor Author

kleini commented Jan 13, 2025

Rebased to include #507. Now everything's green.

gardar
gardar approved these changes Jan 13, 2025
View reviewed changes
Copy link
Member

@gardar gardar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks

@SuperQ SuperQ merged commit ae64725 into prometheus-community:main Jan 13, 2025
661 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gardar gardar gardar approved these changes

Assignees
No one assigned
Labels
bugfix roles/alertmanager roles/bind_exporter roles/blackbox_exporter roles/cadvisor roles/chrony_exporter roles/_common roles/fail2ban_exporter roles/gitlab_ci_pipelines_exporter roles/influxdb_exporter roles/ipmi_exporter roles/memcached_exporter roles/mongodb_exporter roles/mysqld_exporter roles/nginx_exporter roles/node_exporter roles/nvidia_gpu_exporter roles/postgres_exporter roles/process_exporter roles/prometheus roles/pushgateway roles/redis_exporter roles/smartctl_exporter roles/smokeping_prober roles/snmp_exporter roles/systemd_exporter
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow roles to run with INJECT_FACTS_AS_VARS set to false
4 participants
@kleini @mgariepy @gardar @SuperQ