refactor(import): better handling of duplicate packages #156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When importing a package with a duplicate label (one that already exists in storage) proji used to just cancel the import. You had to alter the label of the existing package in order for you to be able to import the new package. Now, when proji detects a duplicate label import it will export the config of the new package into the user cwd. The user can edit the label in the config to his liking and import the config afterwards. Closes #138
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When importing a package with a duplicate label (one that already exists
in storage) proji used to just cancel the import. You had to alter the
label of the existing package in order for you to be able to import the
new package.
Now, when proji detects a duplicate label import it will export the
config of the new package into the user cwd. The user can edit the label
in the config to his liking and import the config afterwards.
Proposed Changes
Resolved Issues
Closes #138