Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

With locations #319

Merged
merged 14 commits into from
Jun 18, 2023
Merged

With locations #319

merged 14 commits into from
Jun 18, 2023

Conversation

bartveneman
Copy link
Member

@bartveneman bartveneman commented Apr 16, 2023

Todo

  • store locations for values
  • store locations for aggregate lists
  • store locations for specificities

Refs #298

Notes:

  • This setups seems to consume a lot of memory and that should be addressed, but I'll tackle that separately;
  • The implementation is under an unfriendly __unstable__uniqueWithLocations property when opted-in via the new useUnstableLocations flag. That should be enough warning signs that this isn't ready for prime time yet;

@bartveneman bartveneman self-assigned this Apr 16, 2023
@bartveneman bartveneman linked an issue Jun 12, 2023 that may be closed by this pull request
@bartveneman bartveneman marked this pull request as ready for review June 18, 2023 19:35
@bartveneman bartveneman merged commit 2a313b5 into master Jun 18, 2023
@bartveneman bartveneman deleted the with-locations branch June 18, 2023 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Add context to result (a.k.a. show actual CSS)
1 participant