Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V4 baseline #160

Merged
merged 38 commits into from
Oct 19, 2021
Merged

V4 baseline #160

merged 38 commits into from
Oct 19, 2021

Conversation

dczulada
Copy link
Contributor

@dczulada dczulada commented Oct 5, 2021

Pull requests into cqm-parsers require the following. Submitter and reviewer should ✅ when done. For items that are not-applicable, note it's not-applicable ("N/A") and ✅.

Submitter:

  • This pull request describes why these changes were made.
  • Internal ticket for this PR:
  • Internal ticket links to this PR
  • Code diff has been done and been reviewed
  • Tests are included and test edge cases
  • Tests have been run locally and pass

Reviewer 1:

Name:

  • Code is maintainable and reusable, reuses existing code and infrastructure where appropriate, and accomplishes the task’s purpose
  • The tests appropriately test the new code, including edge cases
  • You have tried to break the code

Reviewer 2:

Name:

  • Code is maintainable and reusable, reuses existing code and infrastructure where appropriate, and accomplishes the task’s purpose
  • The tests appropriately test the new code, including edge cases
  • You have tried to break the code

hossenlopp and others added 30 commits April 25, 2019 09:59
…rk from master. (#39)

* Fixed SDC loading to work with newer DRC measures.
 - Fixed issues with most data criteria getting thrown out.

* Bring over dependabot nokogiri update and the simplexml_parser removal from #30.
[Security] Update nokogiri requirement from ~> 1.8.5 to >= 1.8.5, < 1.11.0
Updates the requirements on [nokogiri](https://github.com/sparklemotion/nokogiri) to permit the latest version.
- [Release notes](https://github.com/sparklemotion/nokogiri/releases)
- [Changelog](https://github.com/sparklemotion/nokogiri/blob/master/CHANGELOG.md)
- [Commits](sparklemotion/nokogiri@v1.8.5...v1.10.3)

* Add the hqmf identifier to a statement reference (#25)
* 2019 standards update entry point fix (#54)
* fixed gem entry point file to be named properly
* fix issue with loading api uploaded files (#55)
* [Security] Bump nokogiri from 1.10.3 to 1.10.4
* Bump cqm-models version to 3.0.0
…1.0 (#67)

* [Security] Update rubyzip requirement from ~> 1.2.2 to >= 1.2.2, < 2.1.0

Updates the requirements on [rubyzip](https://github.com/rubyzip/rubyzip) to permit the latest version.
- [Release notes](https://github.com/rubyzip/rubyzip/releases)
- [Changelog](https://github.com/rubyzip/rubyzip/blob/master/Changelog.md)
- [Commits](rubyzip/rubyzip@v1.2.3...v2.0.0)

Signed-off-by: dependabot-preview[bot] <[email protected]>

* Updated rubyzip dependency to be less than version 2.x, which requires ruby 2.4
* Updated version of bonnie_version cqm-parser branch

* Updated cqm-parser (binnie_viersion branch)
Bumps [rake](https://github.com/ruby/rake) from 12.3.1 to 12.3.3. **This update includes a security fix.**
- [Release notes](https://github.com/ruby/rake/releases)
- [Changelog](https://github.com/ruby/rake/blob/master/History.rdoc)
- [Commits](ruby/rake@v12.3.1...v12.3.3)

Signed-off-by: dependabot-preview[bot] <[email protected]>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
* made necessary upgrades to line up with bonnie's rails upgrade -> 5.2

* removed deprecated require

* updated codecov (0.1.14 -> 0.2.5) and json (2.1.0 -> 2.3.1) to fix 'Title: json Gem for Ruby Unsafe Object Creation Vulnerability (additional fix)'
* cqm-models 3.0.0 -> 3.0.3

* ran bundle install
* BONNIEMAT-623 & BONNIEMAT-629 cql-integration change

* cqm-models version upgrade
#114)

* Replacing vsac username/password with api key.
…ore checking sub-hash.

When QDM datatype template has includeSubTemplate, the single_code_concepts hash will not have a related key to access the sub-hash.
* MAT-2803 Update Bonnie to support UTF8 - QDM

* Ruby 2.7.2 warnings fix
* MAT-2647 Update cqm-parsers to QDM 5.6

* MAT-2647 Update cqm-parsers to QDM 5.6

* added git actions

* removed travis.yaml
@codecov-commenter
Copy link

codecov-commenter commented Oct 6, 2021

Codecov Report

Merging #160 (4ce41c8) into master (fd4d124) will increase coverage by 0.10%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #160      +/-   ##
==========================================
+ Coverage   82.40%   82.50%   +0.10%     
==========================================
  Files          69       69              
  Lines        4320     4351      +31     
==========================================
+ Hits         3560     3590      +30     
- Misses        760      761       +1     
Impacted Files Coverage Δ
lib/hqmf-parser/2.0/population_criteria.rb 93.44% <100.00%> (ø)
...rser/cql/document_helpers/doc_population_helper.rb 98.90% <100.00%> (+0.03%) ⬆️
lib/measure-loader/mat_measure_files.rb 95.34% <100.00%> (ø)
lib/measure-loader/source_data_criteria_loader.rb 100.00% <100.00%> (ø)
lib/measure-loader/vsac_value_set_loader.rb 100.00% <100.00%> (ø)
lib/util/vsac_api.rb 98.07% <100.00%> (ø)
lib/hqmf-parser/2.0/document.rb 90.83% <0.00%> (-0.70%) ⬇️
lib/hqmf-parser/2.0/data_criteria.rb 81.39% <0.00%> (-0.30%) ⬇️
...rser/2.0/document_helpers/doc_population_helper.rb 77.88% <0.00%> (-0.12%) ⬇️
... and 22 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b42e293...4ce41c8. Read the comment docs.

luis1van
luis1van previously approved these changes Oct 7, 2021
@dczulada dczulada requested a review from adongare October 7, 2021 19:39
@dczulada
Copy link
Contributor Author

dczulada commented Oct 7, 2021

@adongare This PR should mirror the bonnie_version (with the exception of the gemspec/gemfile). There are a few extra lines that were removed to make rubocop happy as well.

@dczulada dczulada merged commit 7cb8ae9 into master Oct 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants