Mark version as dynamic in pyproject.toml
#146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We need to set `dynamic = ["version"]` in `pyproject.toml`, since the spec requires that required fields must be listed in `dynamic` if they're to be provided by the build backend (maturin for us). See PyO3/maturin#2390 for the maturin issue to adhere to the spec.
Benchmark for 2846362Click to view benchmark
|
schemen
approved these changes
Dec 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to set
dynamic = ["version"]inpyproject.toml, since the spec requires that required fields must be listed indynamicif they're to be provided by the build backend (maturin for us).See PyO3/maturin#2390 for the maturin issue to adhere to the spec.
Checklist
bug,enhancement,documentation,change,breaking,dependency,internalas they show up in the changelog