Add explicit HTTP request timeouts #892
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simu
changed the title
simu
force-pushed
the
feat/explicit-request-timeouts
branch
2 times, most recently
from
2499628 to
b73218d
Compare
bastjan
approved these changes
Nov 29, 2023
We've vendored kube.libsonnet in Commodore a while ago to allow us to make updates to support recent Kubernetes versions. Because Commodore will always setup the Jsonnet search paths to include the vendored kube.libsonnet, there's no need to download the upstream copy for the `commodore.libjsonnet` tests.
simu
force-pushed
the
feat/explicit-request-timeouts
branch
from
b73218d to
ba3a771
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The HTTP request timeout can be configured through a new command line flag (or associated environment variable). If the parameter isn't provided, we use a request timeout of 5 seconds.
Resolves #758
Checklist
bug,enhancement,documentation,change,breaking,dependency,internalas they show up in the changelog